Skip to main content

Bug Tracker

Side navigation

#3248 closed bug (fixed)

Opened August 12, 2008 07:14PM UTC

Closed August 12, 2008 07:35PM UTC

Last modified October 29, 2008 01:13AM UTC

Simple solution to Array.prototype.call + jQuery.makeArray conflict

Reported by: flesler Owned by: flesler
Priority: major Milestone: 1.3
Component: core Version: 1.2.6
Keywords: Cc: john,brandon,joern,davidserduke
Blocked by: Blocking:
Description

This is a possible fix to this annoying conflict.

Attachments (1)
Change History (4)

Changed August 12, 2008 07:16PM UTC by flesler comment:1

status: newassigned

This will remove support for functions (regexps still supported) on makeArray.

This passes all the tests on IE6, FF2, Opera 9.2, Opera 9.5, Safari 3. I assume the rest will follow.

I don't think it'll be an issue to drop this support as functions sent to the jQuery constructor are intercepted by init().

Shall I ?

Changed August 12, 2008 07:17PM UTC by flesler comment:2

Related tickets (all rejected in the past by me):

#3079, #3026, #3176, #3202, #3129.

Changed August 12, 2008 07:35PM UTC by flesler comment:3

resolution: → fixed
status: assignedclosed

John approves :)

Applied at [5825].

Changed October 29, 2008 01:13AM UTC by flesler comment:4

Now that isFunction is much shorter and faster, re added support for functions on [5915].