Bug Tracker

Opened 11 years ago

Closed 11 years ago

Last modified 11 years ago

#3248 closed bug (fixed)

Simple solution to Array.prototype.call + jQuery.makeArray conflict

Reported by: flesler Owned by: flesler
Priority: major Milestone: 1.3
Component: core Version: 1.2.6
Keywords: Cc: john, brandon, joern, davidserduke
Blocked by: Blocking:

Description

This is a possible fix to this annoying conflict.

Attachments (1)

makeArray[5824].diff (1.6 KB) - added by flesler 11 years ago.

Download all attachments as: .zip

Change History (5)

Changed 11 years ago by flesler

Attachment: makeArray[5824].diff added

comment:1 Changed 11 years ago by flesler

Status: newassigned

This will remove support for functions (regexps still supported) on makeArray. This passes all the tests on IE6, FF2, Opera 9.2, Opera 9.5, Safari 3. I assume the rest will follow.

I don't think it'll be an issue to drop this support as functions sent to the jQuery constructor are intercepted by init().

Shall I ?

comment:2 Changed 11 years ago by flesler

Related tickets (all rejected in the past by me): #3079, #3026, #3176, #3202, #3129.

comment:3 Changed 11 years ago by flesler

Resolution: fixed
Status: assignedclosed

John approves :) Applied at [5825].

comment:4 Changed 11 years ago by flesler

Now that isFunction is much shorter and faster, re added support for functions on [5915].

Note: See TracTickets for help on using tickets.