Skip to main content

Bug Tracker

Side navigation

#3194 closed enhancement (invalid)

Opened July 28, 2008 04:24PM UTC

Closed July 26, 2010 12:21AM UTC

Possible optimization for the selector module

Reported by: flesler Owned by: flesler
Priority: minor Milestone: 1.3
Component: selector Version: 1.2.6
Keywords: attr Cc:
Blocked by: Blocking:

This reduces the code size and makes things more straight forward.

But could be slower than the actual code...

Attachments (1)
Change History (5)

Changed July 28, 2008 05:41PM UTC by flesler comment:1

This adds a LOT of overhead :(

Changed July 29, 2008 05:26PM UTC by joern comment:2

resolution: → invalid
status: newclosed

The performance overhead isn't worth the code improvement.

Changed July 29, 2008 05:29PM UTC by joern comment:3

resolution: invalid
status: closedreopened

The code to be removed is redundant with attr, maybe a refactoring is a better approach.

Changed July 30, 2008 10:44PM UTC by flesler comment:4

I don't see why "redundant". Using attr() is the logical approach, it just adds too much overhead.

Changed July 26, 2010 12:21AM UTC by dmethvin comment:5

resolution: → invalid
status: reopenedclosed

This doesn't apply anymore since Sizzle was introduced.