Bug Tracker

Opened 11 years ago

Closed 11 years ago

#3162 closed bug (invalid)

Typo in clone function causes error in IE

Reported by: hjess Owned by: flesler
Priority: major Milestone: 1.3
Component: core Version: 1.2.6
Keywords: Cc:
Blocked by: Blocking:

Description

After "ret" is assigned as the result of "this.map", events are processed according to "this", rather than to "ret".

Attachments (1)

jquery.diff (852 bytes) - added by hjess 11 years ago.
diff file

Download all attachments as: .zip

Change History (5)

Changed 11 years ago by hjess

Attachment: jquery.diff added

diff file

comment:1 Changed 11 years ago by flesler

need: ReviewTest Case

Eh.. I'm not sure that's wrong. I really can't follow that piece of code completely.

Can you provide a test case that shows the situation where this causes an error ? Just a simple html file with the needed js.

Thanks

comment:2 Changed 11 years ago by zimbatm

After "ret" is assigned as the result of "this.map", events are processed according to "this", rather than to "ret".

Yes, because events are copied from this to the cloned elements. This is why this and it's childs must be visited.

comment:3 Changed 11 years ago by flesler

Owner: set to flesler
Status: newassigned

Will check this out more closely when I get some time.

comment:4 Changed 11 years ago by dmethvin

Resolution: invalid
Status: assignedclosed

It looks correct as-is; "this" is the original elements and clone is the cloned elements.

Note: See TracTickets for help on using tickets.