Bug Tracker

Opened 8 years ago

Closed 7 years ago

#3137 closed bug (fixed)

Complex selectors breaking .parents() method

Reported by: eduardo Owned by: flesler
Priority: major Milestone: 1.3
Component: selector Version: 1.2.6
Keywords: Cc:
Blocked by: Blocking:

Description (last modified by joern)

If you try to do:

$('body').parents('#fakeId div');

this query should returns 0 elements, but this returns the <html> node.

I found probably a bug on multiFilter method on core, the regex is breaking some selectors.

old regex: expr = f.t.replace(/^\s*,\s*/, "" );

fix for this bug: expr = f.t.replace(/^\s*,?\s*/, "" );

I write a selector test case, and after this change all selectors has passed.

Anyone can confirm is it okay?

Change History (6)

comment:1 Changed 8 years ago by flesler

  • Owner set to flesler
  • Status changed from new to assigned

comment:2 Changed 8 years ago by flesler

/\s*,?\s*/ will match ANYTHING...

comment:3 Changed 8 years ago by flesler

  • Component changed from core to selector
  • need changed from Review to Patch

comment:4 Changed 8 years ago by joern

Related to #2851

comment:5 Changed 8 years ago by joern

  • Description modified (diff)

comment:7 Changed 7 years ago by dmethvin

  • Resolution set to fixed
  • Status changed from assigned to closed

This is fixed in 1.3

Note: See TracTickets for help on using tickets.