Opened 11 years ago
Closed 11 years ago
#3137 closed bug (fixed)
Complex selectors breaking .parents() method
| Reported by: | eduardo | Owned by: | flesler |
|---|---|---|---|
| Priority: | major | Milestone: | 1.3 |
| Component: | selector | Version: | 1.2.6 |
| Keywords: | Cc: | ||
| Blocked by: | Blocking: |
Description (last modified by )
If you try to do:
$('body').parents('#fakeId div');
this query should returns 0 elements, but this returns the <html> node.
I found probably a bug on multiFilter method on core, the regex is breaking some selectors.
old regex:
expr = f.t.replace(/^\s*,\s*/, "" );
fix for this bug:
expr = f.t.replace(/^\s*,?\s*/, "" );
I write a selector test case, and after this change all selectors has passed.
Anyone can confirm is it okay?
Attachments (3)
Change History (9)
Changed 11 years ago by
| Attachment: | selectors.html added |
|---|
Changed 11 years ago by
| Attachment: | selectors.js added |
|---|
comment:1 Changed 11 years ago by
| Owner: | set to flesler |
|---|---|
| Status: | new → assigned |
comment:2 Changed 11 years ago by
comment:3 Changed 11 years ago by
| Component: | core → selector |
|---|---|
| need: | Review → Patch |
comment:5 Changed 11 years ago by
| Description: | modified (diff) |
|---|
Changed 11 years ago by
| Attachment: | multiFilter_patch.js added |
|---|
comment:7 Changed 11 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
This is fixed in 1.3
Note: See
TracTickets for help on using
tickets.
/\s*,?\s*/ will match ANYTHING...