Skip to main content

Bug Tracker

Side navigation

#3127 closed enhancement (fixed)

Opened July 03, 2008 10:04PM UTC

Closed July 28, 2008 06:31PM UTC

Last modified October 14, 2008 10:18AM UTC

File size optimizations for jQuery.event.special

Reported by: mike.helgeson Owned by: flesler
Priority: minor Milestone: 1.3
Component: event Version: 1.2.6
Keywords: Cc:
Blocked by: Blocking:
Attachments (3)
  • enterleave_patch.js (1.0 KB) - added by mike.helgeson July 05, 2008 06:38PM UTC.

    new hybrid from both versions

  • hover-mike[5762].diff (2.4 KB) - added by flesler July 03, 2008 10:30PM UTC.

    Mike's proposal (378 bytes)

  • hover[5762].diff (2.4 KB) - added by flesler July 03, 2008 10:27PM UTC.

    My proposal (349 bytes)

Change History (3)

Changed July 03, 2008 10:35PM UTC by flesler comment:1

need: PatchCommit
status: newassigned

Both patches include the removal of 2 needless "return;".

The amount of bytes is calculated after minifying with Dean's Packer, having the name munging option on.

My proposal is inspired on Mike's. It slightly modifies the behavior, as no special event is created for IE and the handler isn't exposed. Overall, it will work faster and takes less code.

Still... could be better to skip some of the optimizations.

Opinions ?

Changed July 05, 2008 06:43PM UTC by mike.helgeso comment:2

Hybrid version for expands further on Ariels changes... It makes the withinElement function the

actual handler, which is shared by both events (and not exposed). This version is not aggressive with variable references because I think "minifying" does not munge variable names, it just removes comments and whitespace.

Changed July 28, 2008 06:31PM UTC by flesler comment:3

resolution: → fixed
status: assignedclosed

Applied yours at [5797] only with slight modifications.