#3127 closed enhancement (fixed)
File size optimizations for jQuery.event.special
| Reported by: | mike.helgeson | Owned by: | flesler |
|---|---|---|---|
| Priority: | minor | Milestone: | 1.3 |
| Component: | event | Version: | 1.2.6 |
| Keywords: | Cc: | ||
| Blocked by: | Blocking: |
Description
Attachments (3)
Change History (6)
Changed 15 years ago by
| Attachment: | hover[5762].diff added |
|---|
comment:1 Changed 15 years ago by
| need: | Patch → Commit |
|---|---|
| Status: | new → assigned |
Both patches include the removal of 2 needless "return;".
The amount of bytes is calculated after minifying with Dean's Packer, having the name munging option on.
My proposal is inspired on Mike's. It slightly modifies the behavior, as no special event is created for IE and the handler isn't exposed. Overall, it will work faster and takes less code.
Still... could be better to skip some of the optimizations. Opinions ?
comment:2 Changed 15 years ago by
Hybrid version for expands further on Ariels changes... It makes the withinElement function the actual handler, which is shared by both events (and not exposed). This version is not aggressive with variable references because I think "minifying" does not munge variable names, it just removes comments and whitespace.
comment:3 Changed 15 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
Applied yours at [5797] only with slight modifications.
My proposal (349 bytes)