Skip to main content

Bug Tracker

Side navigation

#3082 closed enhancement (fixed)

Opened June 24, 2008 04:22PM UTC

Closed February 13, 2009 10:59PM UTC

Last modified March 14, 2012 05:36PM UTC

Speed improvements for jQuery.css("width"/"height") in combination of dimensions.js

Reported by: paul Owned by: john
Priority: major Milestone: 1.3.2
Component: dimensions Version: 1.3.1
Keywords: Cc:
Blocked by: Blocking:

After many tests, the functions outerWidth and outerHeight in dimensions.js, which make calls to innerHeight/innerWidth, and therefore to jQuery.fn.width or jQuery.fn.height, are the main bottleneck of many core interaction modules in jQuery UI.

After investigating, I'm seeing that there's a lot of room for improvement especially in jQuery.css (i.e. the :visible check is quite heavy), and I would like to see if there's anybody who can come up specifically with improvements for



Attachments (3)
  • 3082.patch (2.7 KB) - added by john February 13, 2009 10:51PM UTC.

    Went through and included the best concepts from the previous patches.

  • dimension_patch.js (3.3 KB) - added by mike.helgeson February 13, 2009 09:01PM UTC.

    updated for 1.3.x

  • dimension_pseudo_patch.js (3.3 KB) - added by mike.helgeson February 13, 2009 10:35PM UTC.

    tried to make it more patch ready...

Change History (4)

Changed June 24, 2008 08:43PM UTC by mike.helgeso comment:1

dimension_patch.js can be included after jquery to test. A new jQuery function is added called $.size and some others overwritten. I guess it needs to be run through the test suite and debated and probably improved some more... but its a start.

Changed February 13, 2009 09:42PM UTC by john comment:3

owner: brandonjohn

Changed February 13, 2009 10:59PM UTC by john comment:4

resolution: → fixed
status: newclosed

Fixed in SVN rev [6195].