Bug Tracker

Opened 12 years ago

Closed 11 years ago

Last modified 8 years ago

#3082 closed enhancement (fixed)

Speed improvements for jQuery.css("width"/"height") in combination of dimensions.js

Reported by: paul Owned by: john
Priority: major Milestone: 1.3.2
Component: dimensions Version: 1.3.1
Keywords: Cc:
Blocked by: Blocking:

Description

After many tests, the functions outerWidth and outerHeight in dimensions.js, which make calls to innerHeight/innerWidth, and therefore to jQuery.fn.width or jQuery.fn.height, are the main bottleneck of many core interaction modules in jQuery UI.

After investigating, I'm seeing that there's a lot of room for improvement especially in jQuery.css (i.e. the :visible check is quite heavy), and I would like to see if there's anybody who can come up specifically with improvements for

outerWidth outrHeight

Attachments (3)

dimension_patch.js (3.3 KB) - added by mike.helgeson 11 years ago.
updated for 1.3.x
dimension_pseudo_patch.js (3.3 KB) - added by mike.helgeson 11 years ago.
tried to make it more patch ready…
3082.patch (2.7 KB) - added by john 11 years ago.
Went through and included the best concepts from the previous patches.

Download all attachments as: .zip

Change History (7)

comment:1 Changed 12 years ago by mike.helgeso

dimension_patch.js can be included after jquery to test. A new jQuery function is added called $.size and some others overwritten. I guess it needs to be run through the test suite and debated and probably improved some more... but its a start.

Changed 11 years ago by mike.helgeson

Attachment: dimension_patch.js added

updated for 1.3.x

comment:3 Changed 11 years ago by john

Milestone: 1.31.3.2
Owner: changed from brandon to john
Version: 1.2.61.3.1

Changed 11 years ago by mike.helgeson

Attachment: dimension_pseudo_patch.js added

tried to make it more patch ready...

Changed 11 years ago by john

Attachment: 3082.patch added

Went through and included the best concepts from the previous patches.

comment:4 Changed 11 years ago by john

Resolution: fixed
Status: newclosed

Fixed in SVN rev [6195].

Note: See TracTickets for help on using tickets.