Bug Tracker

Opened 12 years ago

Closed 12 years ago

Last modified 11 years ago

#3048 closed bug (fixed)

QUnit/testrunner.js fails when error message contains XML-interpreted characters

Reported by: bdumon Owned by: flesler
Priority: minor Milestone:
Component: qunit Version:
Keywords: qunit Cc:
Blocked by: Blocking:

Description

When a test throws an exception and the exception message contains characters with an XML-meaning, the testrunner will fail with a SAXParseException.

For example, I've got a test which throws an exception whose message is like this:

The element type "input" must be terminated by the matching end-tag "</input>"

which will in turn cause an error like:

test_core: Wrapped java.lang.RuntimeException: org.xml.sax.SAXParseException: The element type "wrap" must be terminated by the matching end-tag "</wrap>". (file:/home/bruno/projects/kauri/trunk/modules/kauri-forms/kauri-forms-framework/../kauri-forms-jquery/src/main/kauri/js/testrunner.js#146)

The solution is either to escape any special characters in the message string, or to not interprete it as HTML.

In the attached patch, I take the latter approach.

Attachments (1)

testrunner-innerhtml-patch.txt (507 bytes) - added by bdumon 12 years ago.
Patch against svn rev 5726

Download all attachments as: .zip

Change History (4)

Changed 12 years ago by bdumon

Patch against svn rev 5726

comment:1 Changed 12 years ago by flesler

need: ReviewCommit
Owner: changed from joern to flesler
Status: newassigned

comment:2 Changed 12 years ago by flesler

Resolution: fixed
Status: assignedclosed

Fixed at [5730]. I actually added the same modification before checking your patch. I modified the "informal" version of qunit, I'll let Joern know about this change. Thanks for reporting.

comment:3 Changed 11 years ago by joern

Now also part of QUnit itself, see [5812].

Note: See TracTickets for help on using tickets.