Opened 12 years ago
Closed 11 years ago
#2969 closed bug (wontfix)
Add failsafe check to jQuery.ready()
| Reported by: | sun | Owned by: | |
|---|---|---|---|
| Priority: | major | Milestone: | 1.3 |
| Component: | event | Version: | 1.2.5 |
| Keywords: | ready, readylist, readylist.push | Cc: | sun |
| Blocked by: | Blocking: |
Description
I just spent plenty of time to debug why all of my JavaScript was broken and finally found out that a single function name inside of document.ready(example_function()) was not callable. Would a simple patch as in http://sun.pastebin.us/pastebin.php?diff=d64e38491 (or similar) be accepted?
Attachments (1)
Change History (6)
Changed 12 years ago by
| Attachment: | jquery.ready-callable.patch added |
|---|
comment:1 Changed 12 years ago by
I think it's easy to realize you made a mistake if all fails, than having one single function not executing that you don't know why.
comment:2 Changed 12 years ago by
| Component: | core → event |
|---|
comment:3 Changed 11 years ago by
This seems like the wrong way to address the problem. The proposed patch silently ignores any argument that isn't a function. The current behavior throws an error, so it's at least giving some hint that there is a problem in the code.
comment:4 Changed 11 years ago by
Please close this issue. (I can't see how/where I could do that)
I was dumb, and jQuery improved over time.
comment:5 Changed 11 years ago by
| Cc: | sun added |
|---|---|
| Resolution: | → wontfix |
| Status: | new → closed |
Patch against jQuery 1.2.6