Skip to main content

Bug Tracker

Side navigation

#2908 closed feature (fixed)

Opened May 20, 2008 11:06PM UTC

Closed May 25, 2008 10:10PM UTC

Patch - Validate Plugin - Custom Messages in Metadata

Reported by: DaneOConnor Owned by: joern
Priority: major Milestone: 1.2.4
Component: plugin Version: 1.2.3
Keywords: validate Cc:
Blocked by: Blocking:

Attached is a patch for the validate plugin. The patched plugin supports custom messages specified in metadata. It also includes a small example using the new feature in a few different ways.

If there is anything I should change let me know :)

Attachments (4)
Change History (8)

Changed May 21, 2008 12:14AM UTC by scott.gonzal comment:1

Dane, can you please re-create the patch with Unix line-endings? The patch currently shows that every line has changed and I can't apply it to my working copy to review the changes. Thanks.

Changed May 21, 2008 02:37PM UTC by DaneOConnor comment:2

Ok, I converted the patch. It should now have Unix line endings, though I'm not totally sure. Does it work?

Changed May 22, 2008 11:49AM UTC by joern comment:3

That patch still tries to replace everything, that isn't helpful. It looks like you need to convert line-endings before creating the patch.

Changed May 22, 2008 02:56PM UTC by DaneOConnor comment:4

Ok, sorry about all that. I've never really had to deal with that issue before. I test applied the patch and it looks like its working. If, this doesn't work I suppose I'll just list my changes manually.

Additionally, the change @ lines 124-131 doesn't really change behavior. It just made it a lot easier for me to debug when I was playing with some ideas.

Changed May 25, 2008 11:31AM UTC by joern comment:5

I've commited test in [5690]. The latest patch works much better, but I still have trouble applying it. I'll commit it once I figured it out.

Changed May 25, 2008 11:32AM UTC by joern comment:6

owner: → joern

Changed May 25, 2008 03:11PM UTC by scott.gonzal comment:7

I have no idea what's going on with these patches. I manually added the changes from Dane's patch and created a new patch (meta-messages.patch). Even though the patch was made with Unix line endings, Eclipse is still converting the entire file to Windows line-endings when applying the patch.

Right now, you should be able to apply my patch and get the changes. If Eclipse does switch the line endings when you apply, just use File -> Convert Line Delimiters To -> Unix. I'm really not sure what Eclipse's problem is right now. Perhaps we should consider setting eol-style: native for all source files (I've already done this for core and UI).

I didn't actually have time to review the patch, but from a quick look it seems fine.

Changed May 25, 2008 10:10PM UTC by joern comment:8

resolution: → fixed
status: newclosed

Fixed in [5695], thanks Dane for the patch and Scott for the help.