Opened 15 years ago
Closed 15 years ago
#2857 closed bug (fixed)
[ui.dialog] Exceptions thrown if positioning in iframe
| Reported by: | tyler | Owned by: | paul |
|---|---|---|---|
| Priority: | critical | Milestone: | 1.2.4 |
| Component: | ui | Version: | 1.2.3 |
| Keywords: | Cc: | ||
| Blocked by: | Blocking: |
Description
If you're in a less-than-stellar browser (Safari 2, IE6) that has certain security restraints on trying to set the position of "top" from inside a frame (besides it being an object) currently dialog.position() will thrown an exception that will break the entire page.
The attached patch will safely set "top" in Firefox and such, and have certain fallback behavior for browsers that have issues with iframes trying set "top".
Attachments (1)
Change History (3)
Changed 15 years ago by
| Attachment: | ui.dialog.js.patch added |
|---|
comment:1 Changed 15 years ago by
Ugh, talk about overengineering, the biggest problem is that it's reassigning the top variable >_<
Note: See
TracTickets for help on using
tickets.
this one's for real