Bug Tracker

Opened 12 years ago

Closed 11 years ago

#2839 closed bug (fixed)

Dynamic adding of a remote tab causes error

Reported by: sjmittal Owned by: klaus
Priority: major Milestone: 1.2.4
Component: ui Version: 1.2.3
Keywords: ui.tabs Cc:
Blocked by: Blocking:

Description

Hi, When I add a tab dynamically whose contents are to be pulled from a remote location specified by the url it causes and error. The problem is that it treats the url as callback function. In the add function following code:

if (href)

this.load(index, href);

if to be replaced by

if (href)

this.load(index);

to fix this problem.

If fix is found appropriate please include this is code.

Thanks Sachin

Attachments (1)

jquery-ui-2839.patch (801 bytes) - added by mdalessio 12 years ago.
Submitted patch

Download all attachments as: .zip

Change History (5)

comment:1 Changed 12 years ago by paul

Owner: changed from paul to klaus

comment:2 Changed 12 years ago by mdalessio

I encountered this issue as well, which only occurs for me when trying to invoke tabs() on an empty UL.

In addition to the change made above, one other change is necessary to avoid access non-existent $.data. Full patch is attached.

Changed 12 years ago by mdalessio

Attachment: jquery-ui-2839.patch added

Submitted patch

comment:3 Changed 12 years ago by mdalessio

To reproduce this issue:

  1. invoke tabs() on an empty UL
  2. dynamically add, via tabs('add',...) a remote (Ajax) URL

And again, the above patch allows me to do this with no js errors.

comment:4 Changed 11 years ago by klaus

Resolution: fixed
Status: newclosed
Note: See TracTickets for help on using tickets.