Skip to main content

Bug Tracker

Side navigation

#2802 closed bug (fixed)

Opened May 05, 2008 11:28PM UTC

Closed May 15, 2008 02:46PM UTC

Last modified May 15, 2008 07:30PM UTC

jQuery.curCSS failes in Safari 2.x

Reported by: ebartels Owned by:
Priority: undecided Milestone: 1.2.4
Component: core Version: 1.2.3
Keywords: safari getComputedStyle type error Cc:
Blocked by: Blocking:

changeset [5274] introduces an error in Safari 2.x where calls to jQuery.curCSS will fail with a ''type error''

Apparently, Safari 2 doesn't like the use of ''getComputedStyle'' function, introduced on line 615, in place of the full ''document.defaultView.getComputedStyle''

Attachments (1)
Change History (4)

Changed May 05, 2008 11:37PM UTC by ebartels comment:1

The patch should still take advantage of the optimization from [5274], but when actually making the function call, it uses the full version to keep Safari happy.

Changed May 06, 2008 05:57PM UTC by flesler comment:2

need: ReviewTest Case

I don't see how the optimization is kept.

This needs some testing, but if fails on Safari 2, then we could have a special case where getComputedStyle is a function, that calls internally to document.defaultView.....

Only for Safari 2.x

Changed May 15, 2008 02:46PM UTC by flesler comment:3

resolution: → fixed
status: newclosed

This should be fixed now ([5609]). Could you confirm this ? I don't have Safari 2.

Reopen if it still fails.

Changed May 15, 2008 07:30PM UTC by klaus comment:4

Fixed - that was just in time for me. Thanks Ariel :-)