Bug Tracker

Opened 12 years ago

Closed 12 years ago

Last modified 12 years ago

#2802 closed bug (fixed)

jQuery.curCSS failes in Safari 2.x

Reported by: ebartels Owned by:
Priority: undecided Milestone: 1.2.4
Component: core Version: 1.2.3
Keywords: safari getComputedStyle type error Cc:
Blocked by: Blocking:

Description

changeset [5274] introduces an error in Safari 2.x where calls to jQuery.curCSS will fail with a type error

Apparently, Safari 2 doesn't like the use of getComputedStyle function, introduced on line 615, in place of the full document.defaultView.getComputedStyle

Attachments (1)

ticket2802_safari_curCSS.diff (704 bytes) - added by ebartels 12 years ago.

Download all attachments as: .zip

Change History (5)

Changed 12 years ago by ebartels

comment:1 Changed 12 years ago by ebartels

The patch should still take advantage of the optimization from [5274], but when actually making the function call, it uses the full version to keep Safari happy.

comment:2 Changed 12 years ago by flesler

need: ReviewTest Case

I don't see how the optimization is kept. This needs some testing, but if fails on Safari 2, then we could have a special case where getComputedStyle is a function, that calls internally to document.defaultView.....

Only for Safari 2.x

comment:3 Changed 12 years ago by flesler

Resolution: fixed
Status: newclosed

This should be fixed now ([5609]). Could you confirm this ? I don't have Safari 2.

Reopen if it still fails.

comment:4 Changed 12 years ago by klaus

Fixed - that was just in time for me. Thanks Ariel :-)

Note: See TracTickets for help on using tickets.