$.fn.is and $.fn.not should accept DOMelements and jQuery collections

[paul]

This is basically an addition to #2579. I have had this usecase in almost any UI plugin: The simple task, that I want to see if my DOMelement is within the current jQuery set.

Right now, I have to do something like this:

var inset = false; $(..).each(function() {

if(this == myElement) inset = true;

});

This would be /much/ easier and logical if I could simply do

$(..).is(myElement)

[dmethvin]

Patch still seems to be okay for 1.4.4 and it's been requested a few times.

[ajpiano]

$.fn.not already does accept a DOM element (as does $.fn.filter). +1 on $.fn.is. What *really* needs to take a DOM element that doesn't now is $.fn.find and $.fn.closest, IMO. Thoughts?

[Timmy Willison]

Made a fiddle for this ticket. ​http://jsfiddle.net/timmywil/xWNJe/ $.fn.not works properly, $.fn.is does not. .find() and .closest() fail, but .children() and .parent() pass.

[Timmy Willison]

Something like this might be a start. I'm sure it could be optimized and included in is rather than a new function, but just to use fiddle, here is a newIs that can check objects and raw elements, then passes off to .is() for strings. ​http://jsfiddle.net/timmywil/xWNJe/9/. However, I am using indexOf for an array and I don't think ie6 or ie7 support javascript 1.6. There may be something more clever to use, or a fallback should be written for those browsers.

[Timmy Willison]

Scratch all that. See pull request.

[Rick Waldron]

Can you post a link to the pull request?

[jitter]

3rd party ​pull request

[Timmy Willison]

​Updated pull request Switched to follow jQuery bug patching guidelines.

[john]

Landed.