Side navigation
#2743 closed enhancement (fixed)
Opened April 25, 2008 03:14AM UTC
Closed May 08, 2008 05:23PM UTC
Potpourri of small improvements to code size and perfomance
| Reported by: | flesler | Owned by: | |
|---|---|---|---|
| Priority: | minor | Milestone: | 1.2.4 |
| Component: | core | Version: | 1.2.3 |
| Keywords: | core event fx selector ajax changes | Cc: | |
| Blocked by: | Blocking: |
Description
Hi, this diff contains a large set of small changes that make the code slightly shorter. Some might make the code faster.
Most are redundant vars, or redundant ifs. Also declared undefined as local var and replaced all null for undefined, this should be slightly faster, and make the code much smaller.
I exposed the speeds hash (slow,fast), so it can modified/extended.
I don't remember them all, but their are mostly small changes.
I ran the test suite on IE6 and FF2 and it passed.
Attachments (2)
Change History (5)
Changed April 25, 2008 05:30PM UTC by comment:1
Changed April 28, 2008 02:05PM UTC by comment:2
Sounds like both variations should be send through the benchmark.
Changed April 28, 2008 04:25PM UTC by comment:3
I wasn't really sure about the undefined part, I just added, then you can decide.
There're many small changes, you don't need to take them all, some don't even require testing.
Changed April 30, 2008 12:13AM UTC by comment:4
Added most of these changes at [5357]
Changed May 08, 2008 05:23PM UTC by comment:5
| resolution: | → fixed |
|---|---|
| status: | new → closed |
The local undefined variable is faster than the global undefined property, but slower than null. I think keeping the local undefined variable is a good idea, but null should be used where possible.