Opened 15 years ago
Closed 15 years ago
#2743 closed enhancement (fixed)
Potpourri of small improvements to code size and perfomance
Reported by: | flesler | Owned by: | |
---|---|---|---|
Priority: | minor | Milestone: | 1.2.4 |
Component: | core | Version: | 1.2.3 |
Keywords: | core event fx selector ajax changes | Cc: | |
Blocked by: | Blocking: |
Description
Hi, this diff contains a large set of small changes that make the code slightly shorter. Some might make the code faster.
Most are redundant vars, or redundant ifs. Also declared undefined as local var and replaced all null for undefined, this should be slightly faster, and make the code much smaller.
I exposed the speeds hash (slow,fast), so it can modified/extended. I don't remember them all, but their are mostly small changes.
I ran the test suite on IE6 and FF2 and it passed.
Attachments (2)
Change History (7)
Changed 15 years ago by
Attachment: | potpourri.diff added |
---|
Changed 15 years ago by
Attachment: | possible changes.txt added |
---|
comment:1 Changed 15 years ago by
The local undefined variable is faster than the global undefined property, but slower than null. I think keeping the local undefined variable is a good idea, but null should be used where possible.
comment:3 Changed 15 years ago by
I wasn't really sure about the undefined part, I just added, then you can decide. There're many small changes, you don't need to take them all, some don't even require testing.
comment:5 Changed 15 years ago by
Resolution: | → fixed |
---|---|
Status: | new → closed |
Some more possible changes described