Bug Tracker

Opened 12 years ago

Closed 12 years ago

#2685 closed bug (wontfix)

ui.droppable.js & overflow

Reported by: Maximus Owned by: paul
Priority: minor Milestone: 1.2.4
Component: ui Version: 1.2.3
Keywords: ui droppable overflow dimensions Cc:
Blocked by: Blocking:

Description

I noticed a problem in ui.droppable.js @ line 137. In the event that the drop target has the attribute of overlow: visible, the existing stored values are _NOT_ valid, but are assumed to be so. When this scenario occurs, you cannot do a drag & drop reorder of sub-content past the original dimensions boundaries. For my needs, I needed to deal with Vertical overflow (as most will), and made alterations as follows.

The simple fix is this:
--- t = droppable.offset.top, b = t + droppable.item.proportions.height;
+++ t = droppable.offset.top, b = t + $(droppable.item.element).outerHeight();

Change History (1)

comment:1 Changed 12 years ago by paul

Resolution: wontfix
Status: newclosed

I won't "fix" this due to performance reasons. It makes everything /way/ slower. Anyway, there already is an option that does exactly what you want: call draggable with the option refreshPositions set to true, and it will also update the size on every mousemove. Thanks anyway!

Note: See TracTickets for help on using tickets.