Skip to main content

Bug Tracker

Side navigation

#2620 closed bug (fixed)

Opened March 29, 2008 09:19PM UTC

Closed May 01, 2009 12:22AM UTC

Last modified May 01, 2009 12:22AM UTC

event.fix() possible null dereference

Reported by: jacob Owned by: brandon
Priority: trivial Milestone: 1.4
Component: event Version: 1.2.3
Keywords: Cc:
Blocked by: Blocking:

event.fix() does some checks for document.documentElement being not null before it dereferences them, but not enough.

Attachments (1)
  • event-2620.patch (0.8 KB) - added by jacob March 29, 2008 09:19PM UTC.

    don't dereference doc if it's null

Change History (6)

Changed March 31, 2008 06:56AM UTC by davidserduke comment:1

Are you actually seeing a bug because of this behavior in some browser or is this written up through a code review?

Changed May 16, 2008 03:52AM UTC by flesler comment:2

need: ReviewTest Case

Changed January 15, 2009 03:40AM UTC by dmethvin comment:3

Since doc.scrollLeft is guarded by a check for doc, it does seem like doc.clientLeft should be done the same way. Either that or the check in front of doc.scrollLeft is extraneous. It would help to have a test case though. Is document.documentElement null in quirks mode?

Changed May 01, 2009 12:22AM UTC by brandon comment:4

owner: → brandon

fixed in r6327

Changed May 01, 2009 12:22AM UTC by brandon comment:5

resolution: → fixed
status: newclosed

Changed May 01, 2009 12:22AM UTC by brandon comment:6