Bug Tracker

Opened 12 years ago

Closed 11 years ago

Last modified 11 years ago

#2620 closed bug (fixed)

event.fix() possible null dereference

Reported by: jacob Owned by: brandon
Priority: trivial Milestone: 1.4
Component: event Version: 1.2.3
Keywords: Cc:
Blocked by: Blocking:

Description

event.fix() does some checks for document.documentElement being not null before it dereferences them, but not enough.

Attachments (1)

event-2620.patch (860 bytes) - added by jacob 12 years ago.
don't dereference doc if it's null

Download all attachments as: .zip

Change History (7)

Changed 12 years ago by jacob

Attachment: event-2620.patch added

don't dereference doc if it's null

comment:1 Changed 12 years ago by davidserduke

Are you actually seeing a bug because of this behavior in some browser or is this written up through a code review?

comment:2 Changed 12 years ago by flesler

need: ReviewTest Case

comment:3 Changed 11 years ago by dmethvin

Since doc.scrollLeft is guarded by a check for doc, it does seem like doc.clientLeft should be done the same way. Either that or the check in front of doc.scrollLeft is extraneous. It would help to have a test case though. Is document.documentElement null in quirks mode?

comment:4 Changed 11 years ago by brandon

Owner: set to brandon

fixed in r6327

comment:5 Changed 11 years ago by brandon

Resolution: fixed
Status: newclosed

comment:6 Changed 11 years ago by brandon

Milestone: 1.2.41.3.3
Note: See TracTickets for help on using tickets.