#2620 closed bug (fixed)
event.fix() possible null dereference
| Reported by: | jacob | Owned by: | brandon |
|---|---|---|---|
| Priority: | trivial | Milestone: | 1.4 |
| Component: | event | Version: | 1.2.3 |
| Keywords: | Cc: | ||
| Blocked by: | Blocking: |
Description
event.fix() does some checks for document.documentElement being not null before it dereferences them, but not enough.
Attachments (1)
Change History (7)
Changed 14 years ago by
| Attachment: | event-2620.patch added |
|---|
comment:1 Changed 14 years ago by
Are you actually seeing a bug because of this behavior in some browser or is this written up through a code review?
comment:2 Changed 13 years ago by
| need: | Review → Test Case |
|---|
comment:3 Changed 13 years ago by
Since doc.scrollLeft is guarded by a check for doc, it does seem like doc.clientLeft should be done the same way. Either that or the check in front of doc.scrollLeft is extraneous. It would help to have a test case though. Is document.documentElement null in quirks mode?
comment:5 Changed 12 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
comment:6 Changed 12 years ago by
| Milestone: | 1.2.4 → 1.3.3 |
|---|
Note: See
TracTickets for help on using
tickets.
don't dereference doc if it's null