Skip to main content

Bug Tracker

Side navigation

#2591 closed bug (fixed)

Opened March 26, 2008 11:29PM UTC

Closed April 13, 2008 05:41PM UTC

Slider size method only returns the width of the slider

Reported by: natecavanaugh Owned by: joern
Priority: major Milestone: 1.2.4
Component: ui Version: 1.2.3
Keywords: Cc:
Blocked by: Blocking:
Description

When checking for a sliders size, the size method only returns it's outerWidth, however, when using a vertical slider, you need the height of the slider, not its width.

The fix is to change this on line 192 in ui.slider.js:

return this.actualSize || (this.actualSize = this.element.outerWidth());

to this:

return this.actualSize || (this.actualSize = (this.options.axis == 'horizontal') ? this.element.outerWidth() : this.element.outerHeight());

Attachments (0)
Change History (3)

Changed March 26, 2008 11:35PM UTC by natecavanaug comment:1

Somehow the pipes are missing:

return this.actualSize | | (this.actualSize = (this.options.axis == 'horizontal') ? this.element.outerWidth() : this.element.outerHeight());

Changed March 27, 2008 02:32PM UTC by paul comment:2

owner: pauljoern

Changed April 13, 2008 05:41PM UTC by joern comment:3

resolution: → fixed
status: newclosed

That got fixed some time ago, see latest revision.