Bug Tracker

Opened 12 years ago

Closed 11 years ago

#2555 closed bug (invalid)

Dojo ShrinkSafe compatibility fix

Reported by: SickeW Owned by:
Priority: minor Milestone: 1.2.4
Component: core Version: 1.2.3
Keywords: Cc:
Blocked by: Blocking:

Description

jQuery version 1.2.3 cannot be correctly compressed with Dojo ShrinkSafe. The occurences of variable name 'expando' are not properly replaced within the body of function 'jQuery.fn'. Resulting in an error when the compressed script is used.

This can be verified by pasting 'jquery-1.2.3.js' in 'http://compressorrater.thruhere.net/' and reviewing the result for 'Dojo ShrinkSafe'.

The solution is to put the declaration of variable 'expando' before function 'jQuery.fn'.

Attached a patch against revision 5091.

Sicke Westerdijk.

Attachments (1)

jquery-shrinksafe.patch (666 bytes) - added by SickeW 12 years ago.

Download all attachments as: .zip

Change History (2)

Changed 12 years ago by SickeW

Attachment: jquery-shrinksafe.patch added

comment:1 Changed 11 years ago by dmethvin

Resolution: invalid
Status: newclosed

Sorry, it looks like this ticket got lost. The lines you wanted to change don't seem to be there anymore, I hope that means it's no longer a problem.

Note: See TracTickets for help on using tickets.