Side navigation
#2513 closed enhancement (invalid)
Opened March 14, 2008 03:23PM UTC
Closed July 12, 2008 04:39PM UTC
Accordion: classNames should be default
| Reported by: | neojp | Owned by: | joern |
|---|---|---|---|
| Priority: | trivial | Milestone: | |
| Component: | ui | Version: | |
| Keywords: | Cc: | ||
| Blocked by: | Blocking: |
Description
Theme related classNames should be added to the accordions by default.
$(container).addClass("ui-accordion-container ui-accordion");
// add classNames and spans to header
options.headers.addClass('ui-accordion-link').prepend('<span class="ui-accordion-left"></span>').append('<span class="ui-accordion-right"></span>');
Attachments (2)
Change History (5)
Changed March 14, 2008 03:28PM UTC by comment:1
Changed March 14, 2008 04:35PM UTC by comment:2
| owner: | paul → joern |
|---|
Changed March 16, 2008 04:06AM UTC by comment:3
Why are both .ui-accordion and .ui-accordion-container needed if they're applied to the same element?
Also, why is relative positioning required? I'm asking because this was actually removed in [4420] to fix #2127.
Changed March 23, 2008 06:36PM UTC by comment:4
postion:relative; is not that necessary if you don't append the header spans. If they are not positioned inside a reltive they will appear on the top right corner of the document.
Regarding this,
$(container).addClass("ui-accordion-container ui-accordion");
I'm not sure why the accordion plugin uses 2 different classNames for the same element, since it never uses one. I think we could get rid of one and change the css styles to match the className choosen.
Changed July 12, 2008 04:39PM UTC by comment:5
| resolution: | → invalid |
|---|---|
| status: | new → closed |
The second class got removed, other issues are now on the UI bugtracker.
Talking about a theming issue, headers should be relative positioned.
ul.ui-accordion-container li a.ui-accordion-link { position: relative }