Bug Tracker

#250 closed bug (fixed)

Opened October 06, 2006 09:49AM UTC

Closed October 06, 2006 12:53PM UTC

Last modified June 20, 2007 02:11AM UTC

wrong safari detection

Reported by: matthieu.paineau@wan Owned by:
Priority: critical Milestone:
Component: core Version:
Keywords: safari Cc:
Blocked by: Blocking:
Description

Safari is not truly detected because mozilla detection is quite wrong :

Currently when you are in safari, jQuery.browser.safari is true, but jQuery.browser.mozilla is true too, so we go into mozilla condition but never in safari condition.

You should change this code ...

// Figure out what browser is being used
jQuery.browser = {
	safari: /webkit/.test(b),
	opera: /opera/.test(b),
	msie: /msie/.test(b) && !/opera/.test(b),
	mozilla: /mozilla/.test(b) && !/compatible/.test(b)
};

By this code :

// Figure out what browser is being used
jQuery.browser = {
	safari: /webkit/.test(b),
	opera: /opera/.test(b),
	msie: /msie/.test(b) && !/opera/.test(b),
	mozilla: /mozilla/.test(b) && !/compatible/.test(b) && !/webkit/.test(b)
};
Attachments (0)
Change History (1)

Changed October 06, 2006 12:53PM UTC by joern comment:1

resolution: → fixed
status: new → closed

I'm not sure when, but it has already been fixed in SVN:

mozilla: /mozilla/.test(b) && !/(compatible|webkit)/.test(b)