Bug Tracker

Opened 13 years ago

Closed 13 years ago

Last modified 12 years ago

#250 closed bug (fixed)

wrong safari detection

Reported by: matthieu.paineau@… Owned by:
Priority: critical Milestone:
Component: core Version:
Keywords: safari Cc:
Blocked by: Blocking:

Description

Safari is not truly detected because mozilla detection is quite wrong :

Currently when you are in safari, jQuery.browser.safari is true, but jQuery.browser.mozilla is true too, so we go into mozilla condition but never in safari condition.

You should change this code ...

// Figure out what browser is being used
jQuery.browser = {
	safari: /webkit/.test(b),
	opera: /opera/.test(b),
	msie: /msie/.test(b) && !/opera/.test(b),
	mozilla: /mozilla/.test(b) && !/compatible/.test(b)
};

By this code :

// Figure out what browser is being used
jQuery.browser = {
	safari: /webkit/.test(b),
	opera: /opera/.test(b),
	msie: /msie/.test(b) && !/opera/.test(b),
	mozilla: /mozilla/.test(b) && !/compatible/.test(b) && !/webkit/.test(b)
};

Change History (1)

comment:1 Changed 13 years ago by joern

Resolution: fixed
Status: newclosed

I'm not sure when, but it has already been fixed in SVN:

mozilla: /mozilla/.test(b) && !/(compatible|webkit)/.test(b)
Note: See TracTickets for help on using tickets.