Skip to main content

Bug Tracker

Side navigation

#2477 closed bug (fixed)

Opened March 09, 2008 01:37AM UTC

Closed May 04, 2008 09:01AM UTC

Safari 2.0.4 and Sortables

Reported by: shelane Owned by: braeker
Priority: major Milestone: 1.2.4
Component: ui Version: 1.2.3
Keywords: Cc:
Blocked by: Blocking:

Try to drag anything and it either wants to become the

first or last item leaving only a hole behind in it's place. If you

do the toArray call, the order is the original order.

Attachments (1)
  • safari_contains_2477.diff (3.1 KB) - added by ebartels March 12, 2008 09:33PM UTC.

    Reimpliment contains functionality to work with safari2

Change History (4)

Changed March 12, 2008 07:34PM UTC by ebartels comment:1

It looks like problems are caused by the ''Node.contains'' DOM function. It's supposed to return true if one node contains another, but as far as I can tell the Safari 2 implementation is buggy and always returns true for sibling nodes. This function is used in several places within ui.sortables.js. To get Safari 2 working we're going to need an alternative way to find out if one node contains another.

Changed March 12, 2008 09:42PM UTC by ebartels comment:2

I'm submitting a patch to work around Safari's buggy Node.contains function. I've added a standalone function called contains. It's not as pretty, but since Safari 2 doesn't expose Node.prototype, we can't override it directly.

Tested in ie 6/7, firefox 2, opera, and safari 2/3.

Changed April 01, 2008 06:49PM UTC by paul comment:3

owner: paulbraeker

Changed May 04, 2008 09:01AM UTC by paul comment:4

resolution: → fixed
status: newclosed

Fixed in r5403.