Bug Tracker

Opened 12 years ago

Closed 12 years ago

Last modified 8 years ago

#2360 closed bug (fixed)

[treeview] Branches with checkboxes

Reported by: morrijr Owned by: joern
Priority: major Milestone:
Component: plugin Version:
Keywords: treeview Cc:
Blocked by: Blocking:

Description

Hi Jörn

The problem I've got is that I need to be able to have a checkbox on each branch/node, but clicking the checkbox of a branch in addition to toggling the checkbox expands/collapses the branch.

Can you help? I can't see what's causing this. This is a regression from 1.3.

Thanks,

J.

Attachments (1)

experimental.zip (44.5 KB) - added by morrijr 12 years ago.
Test case

Download all attachments as: .zip

Change History (4)

Changed 12 years ago by morrijr

Attachment: experimental.zip added

Test case

comment:1 Changed 12 years ago by morrijr

The change that is causing this is in the applyClasses function.

From (1.3)

this.filter(":has(>ul):not(:has(>a))").find(">span").click(function(event) {
    if ( this == event.target ) {
        toggler.apply($(this).next());
    }
}).add( $("a", this) ).hoverClass();

to (1.4)

this.filter(":has(>ul):not(:has(>a))").find(">span").click(function(event) {
    toggler.apply($(this).next());
}).add( $("a", this) ).hoverClass();

Was there a reason this if was removed?

comment:2 Changed 12 years ago by joern

Keywords: branch checkbox removed
Milestone: 1.2.4
need: ReviewCommit
Owner: set to joern
Summary: [TreeView] Branches with checkboxes[treeview] Branches with checkboxes
Version: 1.2.3

Note: Add comment why the check is necessary.

comment:3 Changed 12 years ago by joern

Resolution: fixed
Status: newclosed

Fixed in [5100].

Note: See TracTickets for help on using tickets.