Skip to main content

Bug Tracker

Side navigation

#2288 closed enhancement (wontfix)

Opened February 06, 2008 11:54PM UTC

Closed October 03, 2010 10:18PM UTC

Ease of use enhancement for .show("slow")/.hide("slow")

Reported by: DiscoNova Owned by:
Priority: minor Milestone: 1.2.3
Component: effects Version: 1.2.2
Keywords: Cc:
Blocked by: Blocking:
Description

As per ticket #2041, it's impossible to use the "speed enabled" show/hide -functions on table-rows (and actually a few other elements whose native display-mode is not "block"), why even offer the possibility of shooting yourself in the foot? When a developer erroneously attempts to do something like that, why not just silently disallow it; a change could be made (for example) by changing this:

  show: function(speed,callback){
    return speed ?


...


  hide: function(speed,callback){
    return speed ?

...into this:

  show: function(speed,callback){
    return !this.is("tr,td,th") && speed ?


...


  hide: function(speed,callback){
    return !this.is("tr,td,th") && speed ?

The reason for this suggestion is that when the display-mode is changed from the native ("table-row" for TR, "table-cell" for TD, etc.) into "block", there are some unwanted side-effects in the rendering engines that could propably cause some mayhem in the long run.

Attachments (0)
Change History (2)

Changed March 11, 2009 05:13PM UTC by dantman comment:1

That's a pretty bad test right there. I've seen plenty of css hack cases where tables were converted into something else with css (even though they are a tr for accessibility, they use other displays when css is enabled) and other things that were converted into tables.

If anything is going to be tested it should probably be the actual display type.

Changed October 03, 2010 10:18PM UTC by snover comment:2

resolution: → wontfix
status: newclosed

A patch has been introduced to allow use of show/hide with tables. This would never be the correct solution anyway.