Opened 15 years ago
Closed 13 years ago
#2279 closed enhancement (fixed)
faster trim
Reported by: | phpmyforum | Owned by: | flesler |
---|---|---|---|
Priority: | minor | Milestone: | 1.4.3 |
Component: | core | Version: | 1.4.2 |
Keywords: | Cc: | phpmyforum | |
Blocked by: | Blocking: |
Description
Maybe everyone had read this already... I think jQuery would really benefit from this:
http://blog.stevenlevithan.com/archives/faster-trim-javascript
Attachments (2)
Change History (9)
comment:1 Changed 15 years ago by
comment:3 Changed 15 years ago by
I actually proposed one, and I think this trim12 is pretty much mine :)
comment:4 Changed 15 years ago by
Milestone: | 1.2.3 → 1.3 |
---|---|
need: | Review → Patch |
Owner: | set to flesler |
Status: | new → assigned |
comment:5 Changed 14 years ago by
Cc: | phpmyforum added |
---|---|
need: | Patch → Commit |
I think I'll add this trim function. We need to do some tests to verify it's a good choice for most situations.
comment:6 Changed 14 years ago by
After fixing #4037, .trim() is no longer used in jQuery core - FYI.
comment:21 Changed 13 years ago by
Milestone: | 1.3 → 1.4.3 |
---|---|
Resolution: | → fixed |
Status: | assigned → closed |
Version: | 1.2.2 → 1.4.2 |
Note: See
TracTickets for help on using
tickets.
Seconded. Specifically, I'd suggest the following version, which is Steve's trim12 function with the null-value fix from bug 1395: