Skip to main content

Bug Tracker

Side navigation

#225 closed bug (fixed)

Opened September 30, 2006 03:34AM UTC

Closed October 03, 2006 06:34PM UTC

[PATCH] IE Memory Leaks from event system

Reported by: brandon.aaron@gmail. Owned by:
Priority: critical Milestone:
Component: event Version:
Keywords: Cc:
Blocked by: Blocking:

Currently jQuery does not take care of the well known memory leak from adding but not removing event handlers in IE. This is a patch to add this in.

The diff:

The example without the fix:

The example with the fix:

The blog entry:

Attachments (0)
Change History (4)

Changed September 30, 2006 02:35PM UTC by joern comment:1

resolution: → fixed
status: newclosed

Added to SVN. Good job Brandon!

Changed October 02, 2006 12:01PM UTC by danyalex comment:2

The hotfix removes the custom unload events also. It's better to check if type == 'unload' before removing the event.

Changed October 03, 2006 03:47PM UTC by brandon.aaro comment:3

resolution: fixed
status: closedreopened

danyalex is correct. Here is an updated patch and example.

The example (you should get an alert onunload):

The diff:

Also this patch fixes a memory leak in Firefox related to the ready event. You can verify using the leak monitor extension vs this unfixed page:

Changed October 03, 2006 06:34PM UTC by joern comment:4

resolution: → fixed
status: reopenedclosed

I added it to SVN. Just reopen this ticket if there are other issues...