Side navigation
#225 closed bug (fixed)
Opened September 30, 2006 03:34AM UTC
Closed October 03, 2006 06:34PM UTC
[PATCH] IE Memory Leaks from event system
| Reported by: | brandon.aaron@gmail. | Owned by: | |
|---|---|---|---|
| Priority: | critical | Milestone: | |
| Component: | event | Version: | |
| Keywords: | Cc: | brandon.aaron@gmail.com | |
| Blocked by: | Blocking: |
Description
Currently jQuery does not take care of the well known memory leak from adding but not removing event handlers in IE. This is a patch to add this in.
The diff: http://brandonaaron.net/jquery/memoryleak/event_leak_fix.diff
The example without the fix: http://brandonaaron.net/jquery/memoryleak/event_leak.html
The example with the fix: http://brandonaaron.net/jquery/memoryleak/event_leak_fix.html
The blog entry: http://brandonaaron.net/articles/2006/09/30/fixing-jquerys-memory-leak
Attachments (0)
Change History (4)
Changed September 30, 2006 02:35PM UTC by comment:1
| resolution: | → fixed |
|---|---|
| status: | new → closed |
Changed October 02, 2006 12:01PM UTC by comment:2
The hotfix removes the custom unload events also. It's better to check if type == 'unload' before removing the event.
Changed October 03, 2006 03:47PM UTC by comment:3
| resolution: | fixed |
|---|---|
| status: | closed → reopened |
danyalex is correct. Here is an updated patch and example.
The example (you should get an alert onunload): http://brandonaaron.net/jquery/memoryleak2/event_leak_fix.html
The diff: http://brandonaaron.net/jquery/memoryleak2/event_leak_fix.diff
Also this patch fixes a memory leak in Firefox related to the ready event. You can verify using the leak monitor extension vs this unfixed page: http://brandonaaron.net/jquery/memoryleak2/event_leak.html
Changed October 03, 2006 06:34PM UTC by comment:4
| resolution: | → fixed |
|---|---|
| status: | reopened → closed |
I added it to SVN. Just reopen this ticket if there are other issues...
Added to SVN. Good job Brandon!