IE6/7 fails in "find" when selector isn't a String

Reported by:	bfattori	Owned by:
Priority:	major	Milestone:	1.2.3
Component:	core	Version:	1.2.2
Keywords:	bug,IE7,IE7,find	Cc:
Blocked by:		Blocking:

Description

When the selector passed to the "find" method (line 284 of 1.2.2 release) is not a String, the method ".indexOf" fails (line 289 of 1.2.2 release).

Wrapping the call as such seems to fix the problem:

... || (selector.indexOf && selector.indexOf("..") > -1) ? ...

However, since I don't fully understand the way jQuery works, I don't know what this might break.

Attachments (0)

Change History (6)

Changed January 18, 2008 03:25AM UTC by davidserduke comment:1

What exactly are you trying to pass in to find that isn't a string?

I think find is only expecting a string:

http://docs.jquery.com/Traversing/find#expr

Changed January 18, 2008 09:05PM UTC by bfattori comment:2

I cannot tell which "find" method this is. There's an internal one, and one exposed to the outside. If this is the outside version, I'll dig deeper, but I believe this is the internal one.

Changed January 18, 2008 09:53PM UTC by davidserduke comment:3

I believe this is the external one jQuery.fn.find() which actually calls the internal one jQuery.find().

Changed January 26, 2008 02:49AM UTC by davidserduke comment:4

need:	Review → Test Case

Do you have a test case that demonstrates your problem? I still don't understand what you are trying to pass in to find().

Changed January 28, 2008 08:31PM UTC by bfattori comment:5

I found the error. You may cancel this bug... I had implemented my own scroll animation handler that was passing an invalid object. With the new jQuery, scrolling is handled natively and removing my plugin fixed the issue.

Sorry for the trouble.

Changed January 29, 2008 06:00AM UTC by davidserduke comment:6

resolution:	→ invalid
status:	new → closed

No problem at all. Glad you found your issue.

Side navigation

#2187 closed bug (invalid)