Bug Tracker

Opened 14 years ago

Closed 14 years ago

Last modified 13 years ago

#217 closed (invalid)

Sabrina

Reported by: joern Owned by:
Priority: Milestone:
Component: Version:
Keywords: Sabrina, SPAM Cc:
Blocked by: Blocking:

Description

This is a summary for all things related to the work on the ajax module. There is quite a lot to do...

Related reports:

http://jquery.com/dev/bugs/bug/196/ - Is this really a problem jQuery needs to care about? Klaus: "In my opinion, jQuery shouldn't be responsible for others bad code."

http://jquery.com/dev/bugs/bug/210/ - Should be handled by merging the form plugin

http://jquery.com/dev/bugs/bug/159/ - Should be applied before merging form plugin, after adding all necessary tests

http://jquery.com/dev/bugs/bug/216/ - much later

http://jquery.com/dev/bugs/bug/195/ - allow local timeout, see handlers below

http://jquery.com/dev/bugs/bug/165/ - catch lastModified exception: start testing logging statements here!

Global and local handlers: Add a global global flag, defaults to true: This will, by default, call all global ajax handlers; Can be changed global (eg. $.ajaxGlobal = false) or per request, eg. $.ajax({..., global: false, ...});

Attaching global handlers to DOM elements doesn't make much sense in most cases, but it is nice to be able to chain them. Check if it is possible to do this:

var start = function() {...};
var stop = function() {...};
$.ajaxStart(start).ajaxStop(stop)

Maybe we should stop putting all and everything into $ namespace:

$.ajax.start(start).stop(stop);

Whatever change is made, complete the tests first and make sure that backwards compability is not broken. Maybe mark methods or functions as deprecated, but delay there "official" removal for a 2.x release. To prevent bloating the code, do this only if it is really useful.

Change History (9)

comment:1 Changed 14 years ago by klaus.hartl@…

regarding http://jquery.com/dev/bugs/bug/196/

Maybe I was a little too harsh here. After all it may be good thing to not break others code, if at all possible. I think it shouldn't be the goal to be compatible to any library out there, especially if these libraries are doing bad regarding coding best-practices (like enhancing the objects prototype), but maybe we can have a look into the issue (low prio if you ask me).

regarding http://jquery.com/dev/bugs/bug/216/

I thought there was already the dataType "html", so with it I expected scripts to be evaluated... If not forget that!

To override the ajax handlers via a global options makes sense to me and is good solution.

The chaining would also be a good thing, as one gets used to it.

$.ajaxStart(start).ajaxStop(stop);

As for the namespace thing, I'm not sure. Could make sense, but we should be careful with changing the API too much. That can be frustrating.

comment:2 Changed 14 years ago by joern

The form plugin has currently some performance issues (see http://jquery.com/discuss/2006-September/012559/ and followups). There are quite some ideas how to improve it, would be best to merge an improved version to core.

comment:3 Changed 14 years ago by joern

Update on form serialize: The current implementation maintains the order of the elements, which can be important in certains cases.

One could use a "fastNoOrder: true" option in case it is not possible to maintain order whith better performance.

comment:4 Changed 14 years ago by joern

Tests are ready and running, still lots of work

comment:5 Changed 14 years ago by joern

Resolution: fixed
Status: newclosed

All important points have been solved.

comment:6 Changed 14 years ago by joern

Component: ajax
Priority: blocker
Resolution: invalid
Status: reopenedclosed
Type: bug

SPAMPOLICE

comment:7 Changed 14 years ago by Sabrina

Cc: Sabrina added; "" removed
Component: ajax1
Keywords: Sabrina added; "" removed
Milestone: 1
Priority: blocker1
Summary: ajax summary / todo listSabrina
Type: bug1
Version: 1

comment:8 Changed 10 years ago by snover

Component: 1
Milestone: 1
Priority: 1
Type: 1
Version: 1

comment:9 Changed 10 years ago by snover

Cc: Sabrina removed
Keywords: SPAM added
Owner: joern deleted
Note: See TracTickets for help on using tickets.