Bug Tracker

Opened 12 years ago

Closed 12 years ago

#2101 closed bug (fixed)

Minor build script issues

Reported by: emartin24 Owned by:
Priority: minor Milestone: 1.2.2
Component: build Version: 1.2.1
Keywords: build, version, pack, dist Cc:
Blocked by: Blocking:

Description

I found a couple of minor issues in the build scripts.

1) In version.js, the @VERSION replace will only happen for the first occurence. To make it do a global replace, the call needs to be changed to: readFile(file).replace(RegExp("@VERSION", "g") I'm not sure if this was intentional, but if it is not a global replace, the @VERSION, currently on line 104, will not be replaced.

2) In pack.js, if the outFile is not specified as an argument, the filename will be jquerypack.js instead of jquery.pack.js. A period needs to be added to "pack.js"

Patches included.

Attachments (1)

build-version-pack.patch (902 bytes) - added by emartin24 12 years ago.
version.js fix for global @VERSION replacement and pack.js fix for outFile filename

Download all attachments as: .zip

Change History (4)

Changed 12 years ago by emartin24

Attachment: build-version-pack.patch added

version.js fix for global @VERSION replacement and pack.js fix for outFile filename

comment:1 Changed 12 years ago by john

Component: corebuild
Resolution: fixed
Status: newclosed

Fixed in SVN rev [4442]. The @VERSION stuff is in the build file now.

comment:2 Changed 12 years ago by emartin24

Resolution: fixed
Status: closedreopened

It looks like the global @VERSION replacement works correctly when building with make, but not ant. The fix I suggested for version.js will correct that.

-Eric

comment:3 Changed 12 years ago by joern

Resolution: fixed
Status: reopenedclosed

Fixed in [4486].

Note: See TracTickets for help on using tickets.