Bug Tracker

Opened 8 years ago

Closed 8 years ago

Last modified 7 years ago

#2076 closed bug (fixed)

$.trim Error: (text || "").replace is not a function

Reported by: apaella@… Owned by:
Priority: major Milestone: 1.2.2
Component: core Version: 1.2.1
Keywords: Cc:
Blocked by: Blocking:


call $.trim($('#id').val()) over a #id empty input throws an Error: (text
"").replace is not a function

$('#id').val() == []

and ([]
"") is not a string...

Change History (2)

comment:1 Changed 8 years ago by davidserduke

  • Resolution set to fixed
  • Status changed from new to closed

Fixed in [4220].

Actually $.trim hasn't changed since 1.2.1 (and probably earlier). This problem was with val() and your test case. The test case doesn't wait till the document is ready so $("#foo").length == 0 as you noted. If you put the code inside

    /* code here */

it will work fine.

But as it turned out this was a good test since val was incorrectly returning an empty array instead of undefined as it used to. One other thing, just for completeness, is your example has an input with type="input" but to my knowledge there is no such input type. Firefox converts that to type="text". I'm not sure what other browsers would do.

comment:2 Changed 8 years ago by apaella@…

ops, sorry fom my double mistake :D

thanks for the patch.

great job!

Note: See TracTickets for help on using tickets.