Bug Tracker

Opened 15 years ago

Closed 15 years ago

Last modified 13 years ago

#2076 closed bug (fixed)

$.trim Error: (text || "").replace is not a function

Reported by: [email protected] Owned by:
Priority: major Milestone: 1.2.2
Component: core Version: 1.2.1
Keywords: Cc:
Blocked by: Blocking:


call $.trim($('#id').val()) over a #id empty input throws an Error: (text
"").replace is not a function

$('#id').val() == []

and ([]
"") is not a string...

Attachments (1)

index.html (511 bytes) - added by [email protected] 15 years ago.
a live example

Download all attachments as: .zip

Change History (3)

Changed 15 years ago by [email protected]

Attachment: index.html added

a live example

comment:1 Changed 15 years ago by davidserduke

Resolution: fixed
Status: newclosed

Fixed in [4220].

Actually $.trim hasn't changed since 1.2.1 (and probably earlier). This problem was with val() and your test case. The test case doesn't wait till the document is ready so $("#foo").length == 0 as you noted. If you put the code inside

    /* code here */

it will work fine.

But as it turned out this was a good test since val was incorrectly returning an empty array instead of undefined as it used to. One other thing, just for completeness, is your example has an input with type="input" but to my knowledge there is no such input type. Firefox converts that to type="text". I'm not sure what other browsers would do.

comment:2 Changed 15 years ago by [email protected]

ops, sorry fom my double mistake :D

thanks for the patch.

great job!

Note: See TracTickets for help on using tickets.