Bug Tracker

Opened 14 years ago

Closed 14 years ago

#2069 closed bug (fixed)

ready issues

Reported by: joern Owned by:
Priority: major Milestone: 1.2.2
Component: core Version: 1.2.1
Keywords: Cc:
Blocked by: Blocking:

Description

I've discovered two issues with 1.2.2b with the ready event:

For once, the event handler doesn't get a reference to jQuery anymore, instead only a (useless for me) event object is passed.

Test:

test("jQuery(function($) {})", function() {
	stop();
	jQuery(function($) {
		equals(jQuery, $, "ready doesn't provide an event object, instead it provides a reference to the jQuery function, see http://docs.jquery.com/Events/ready#fn");
		start();
	});
});

The above test fails due to another issue: Binding a ready event after the event was issued doesn't do anything anymore. In 1.2.1 the handler would be triggered immediately. Though this behaviour isn't documented anywhere, but changing it definitely breaks stuff, so we should be the docs, too. Eg. adding this to http://docs.jquery.com/Events/ready#fn:

<p>If the handler is bound after the event already fired, it is triggered immediately.</p>

No idea how to fix it due to the new special event handling. An introduction to that would be great.

Attachments (1)

2069.diff (2.1 KB) - added by davidserduke 14 years ago.
possible patch

Download all attachments as: .zip

Change History (2)

Changed 14 years ago by davidserduke

Attachment: 2069.diff added

possible patch

comment:1 Changed 14 years ago by brandon

Resolution: fixed
Status: newclosed

Fixed in [4211].

The ready helper method and associated shortcuts act the same as they always have. Using the events API to bind/unbind/trigger the ready event on the document follows the standards within the events API.

Note: See TracTickets for help on using tickets.