Bug Tracker

#201 closed bug (invalid)

Opened September 16, 2006 09:20PM UTC

Closed October 26, 2006 02:24PM UTC

Last modified March 08, 2012 12:16PM UTC

[PATCH] innerWidth and innerHeight fails in IE with no borders

Reported by: brandon.aaron@gmail. Owned by:
Priority: undecided Milestone:
Component: ajax Version:
Keywords: "" Cc: ""
Blocked by: Blocking:
Description

If an element does not have a border the innerWidth and innerHeight functions of the dimensions plugin cause a NaN result. It is a very simple fix. Just need to add 

 || 0
to each of the 
parseInt
calls on line 81 and 99.

Line 81:

this.get(0).offsetHeight - parseInt(this.css("borderTop")) - parseInt(this.css("borderBottom"));

Should now be

this.get(0).offsetHeight - parseInt(this.css("borderTop") || 0) - parseInt(this.css("borderBottom") || 0);

Line 99:

this.get(0).offsetWidth - parseInt(this.css("borderLeft")) - parseInt(this.css("borderRight"));

Should now be

this.get(0).offsetWidth - parseInt(this.css("borderLeft") || 0) - parseInt(this.css("borderRight") || 0);
Attachments (1)
  • dimensions.diff (1.1 KB) - added by brandon.aaron@gmail. September 16, 2006 09:21PM UTC.

    The diff.

Change History (3)

Changed September 17, 2006 10:10AM UTC by joern comment:1

resolution: → fixed
status: new → closed

Fixed in SVN.

Changed October 26, 2006 02:24PM UTC by anonymous comment:2

component: → ajax
priority: → blocker
resolution: → invalid
status: reopened → closed
type: → bug

SPAMPOLICE

Changed March 08, 2012 12:16PM UTC by anonymous comment:3 

#!html

<h3 class='change'>
                  <span class='threading'>
                    <span class='cnum' id='comment:6'>
      <a href='http://le-meilleur-forfait.com/'>comment:6</a>
    </span>
                  </span>
                  Changed <a title='2006-10-07T20:08:56Z in Timeline' href='http://le-meilleur-forfait.com/' class='timeline'>5 years</a> ago by brandon
                </h3>

                  <form action='#comment' method='get' id='reply-to-comment-6'>

                  </form>
                
  <ul class='changes'>
    <li>
      <strong>Status</strong>

        changed from <em>reopened</em> to <em>closed</em>
	<a style='color:white' href='http://le-meilleur-forfait.com/'>forfait mobile</a>
<a style='color:white' href='http://le-meilleur-forfait.com/sans_engagement'>Forfait sans engagement</a>
<a style='color:white'  href='http://le-meilleur-forfait.com/illimite'>Forfait mobile appels illimités</a>
<a style='color:white'  href='http://le-meilleur-forfait.com/sms_illimite'>Forfait sms illimités</a>
<a style='color:white'  href='http://le-meilleur-forfait.com/internet'>Forfait mobile internet</a>
<a style='color:white'  href='http://le-meilleur-forfait.com/bloque'>Forfait bloqué</a>
<a style='color:white'  href='http://le-meilleur-forfait.com/blackberry'>Forfait Blackberry</a>