Skip to main content

Bug Tracker

Side navigation

#2008 closed bug (fixed)

Opened December 05, 2007 06:19AM UTC

Closed December 08, 2007 11:39AM UTC

[PATCH] Open and Close Multiple Dialogs

Reported by: Xichekolas Owned by: rworth
Priority: major Milestone: 1.2.2
Component: ui Version: 1.2.1
Keywords: ui dialog open close Cc:
Blocked by: Blocking:

Two problems:

1. All dialogs were opening with the same data. This made all the close buttons only close the most recently opened dialog. Fixed this by adding the 'new' keyword before the call to $.ui.dialogInit

2. Closing a dialog only sets it to display:none. However, reopening the dialog actually creates a whole duplicate dialog, rather than unhiding the existing one. This is because the if statement that checked to see if the div on which we call .dialog() is already a dialog was checking for the wrong css class (due to the way the dialog is built, the original div gets the .ui-dialog-content class, not the .ui-dialog class.

Attachments (1)
  • ReopenPatch.diff (0.4 KB) - added by Xichekolas December 05, 2007 06:19AM UTC.
Change History (3)

Changed December 05, 2007 07:33AM UTC by davidserduke comment:1

component: coreui

Changed December 05, 2007 09:35AM UTC by rworth comment:2

owner: → rworth
status: newassigned

Changed December 08, 2007 11:39AM UTC by rworth comment:3

resolution: → fixed
status: assignedclosed

Thanks for the patch. Fixed in rev4075.