Side navigation
#196 closed bug (fixed)
Opened September 11, 2006 12:19PM UTC
Closed October 11, 2009 02:13PM UTC
Please dont shaddow XMLHttpRequest
| Reported by: | daniel.doubleday@gmx | Owned by: | |
|---|---|---|---|
| Priority: | undecided | Milestone: | |
| Component: | ajax | Version: | |
| Keywords: | Cc: | ||
| Blocked by: | Blocking: |
Description
This breaks other libraries which distinguish between ie and other via "is defined" checks such as DWR and others.
Please use a factory method instead.
I know that this will break backward compatability but I think the "I know that I'm not alone" approach is worth it.
Attachments (0)
Change History (3)
Changed October 27, 2006 02:58PM UTC by comment:1
| resolution: | → worksforme |
|---|---|
| status: | new → closed |
Changed October 28, 2006 04:00AM UTC by comment:2
| resolution: | worksforme |
|---|---|
| status: | closed → reopened |
I still think we should consider this - this is one area in which we do introduce something into the global namespace, when we really shouldn't.
Changed October 11, 2009 02:13PM UTC by comment:3
| component: | → ajax |
|---|---|
| description: | This breaks other libraries which distinguish between ie and other via "is defined" checks such as DWR and others.\ \ Please use a factory method instead.\ \ I know that this will break backward compatability but I think the "I know that I'm not alone" approach is worth it. → This breaks other libraries which distinguish between ie and other via "is defined" checks such as DWR and others. \ \ Please use a factory method instead. \ \ I know that this will break backward compatability but I think the "I know that I'm not alone" approach is worth it. |
| need: | → Review |
| priority: | → blocker |
| resolution: | → fixed |
| status: | reopened → closed |
| type: | → bug |
If we remove the shadowed XMLHttpRequest, I'd have to remove the fixed event object etc. pp. That can't be the right solution either, therefore I close this report.