#1960 closed enhancement (wontfix)
Name selectors should delegate to document.getElementsByName
Reported by: | sil | Owned by: | |
---|---|---|---|
Priority: | minor | Milestone: | 1.2.4 |
Component: | core | Version: | 1.2.1 |
Keywords: | Cc: | ||
Blocked by: | Blocking: |
Description
The selector $("*[@name=foo]") should delegate to document.getElementsByName("foo"), since getElementsByName is natively implemented and therefore faster. (This assumes that you can recognise this selector type fast enough that it's worth checking for it to do the delegation, of course.)
Attachments (2)
Change History (9)
comment:1 Changed 15 years ago by
comment:2 Changed 15 years ago by
Both patches break "selector module: attributes" test 19. and 20., related to :not()
comment:3 Changed 15 years ago by
I made a few attempts but it just fails when doing :not. I restricted it to only positive filters, see if this passes, I g2g, I'll try to test this myself :)
comment:5 Changed 15 years ago by
Resolution: | fixed |
---|---|
Status: | closed → reopened |
document.getElementsByName can only retrieve elements in the document tree. see #2787
comment:6 Changed 15 years ago by
Resolution: | → wontfix |
---|---|
Status: | reopened → closed |
Right, reverted at [5460], good catch.
comment:7 Changed 15 years ago by
Milestone: | 1.2.2 → 1.2.4 |
---|
I did a quick benchmark, the page had 533 elements, 7 of them matched the name. The call was
Results: