Skip to main content

Bug Tracker

Side navigation

#1921 closed bug (fixed)

Opened November 13, 2007 07:03PM UTC

Closed November 14, 2007 10:25PM UTC

[PATCH] function outerHeight(el) from ui.mouse.js calculates "width"

Reported by: ptab Owned by:
Priority: critical Milestone: 1.2.2
Component: ui Version: 1.2.1
Keywords: outerHeight Cc:
Blocked by: Blocking:
Description

File: ui.mouse.js

Look at the second line of the code: WIDTH !!! should be HEIGHT.

It makes Drag&Drop module not working (tolerance):

function outerHeight(el) {

var $el = $(el), oh = $el.width();

for (var i = 0, props = ['borderTopWidth', 'paddingTop', 'paddingBottom', 'borderBottomWidth']; i < props.length; i++)

oh += num($el, props[i]);

return oh;

}

Attachments (1)
Change History (1)

Changed November 14, 2007 10:25PM UTC by brandon comment:1

resolution: → fixed
status: newclosed

Fixed in Rev [3826].

I just used the dimensions outerWidth and outerHeight methods which were just updated for a boost in performance.