Skip to main content

Bug Tracker

Side navigation

#1887 closed bug (fixed)

Opened November 02, 2007 06:54PM UTC

Closed December 18, 2007 03:14AM UTC

Sortables -- bad options do not fail gracefully, explode

Reported by: Bradley Owned by: rworth
Priority: minor Milestone: 1.2.2
Component: ui Version: 1.2.1
Keywords: ui, sortable, draggable Cc:
Blocked by: Blocking:
Description

Some sortable options do not fail gracefully/silently if passed an argument of the wrong type. For instance, the update option expects a function. If you pass a string by accident, it should fail gracefully but rather goes into an infinite loop of errors.

Infinite loop of errors

$("#list li").sortable({

update: 'oops its a string'

});

A simple conditional could stop this effect:

Pseudocode

if (typeof theargument != 'function') { // fail gracefully }

I've seen this with sortables, specifically the stop and update options, but I'm sure it's in other areas such as draggables also. While it does take human error to trigger it, human error should not make your browser explode.

Attachments (0)
Change History (2)

Changed November 02, 2007 06:57PM UTC by rworth comment:1

owner: → rworth
status: newassigned

Changed December 18, 2007 03:14AM UTC by rworth comment:2

resolution: → fixed
status: assignedclosed

Fixed in [4216]