:contains selector doesn't work for Ajax responses in IE6

[julienw]

Hi,

I wanted to use the selector :contains for Ajax responses, and, while it works perfectly in Firefox, in doesn't work in IE. My guess is that Ajax responses don't have innerText set in IE (whereas in Firefox, they have textContent; I checked that).

The fix below works for me, for my specific case, but it is maybe too much intrusive, or not enough :

I'm changing this line :

contains: "(a.textContent

a.innerText

).indexOf(m[3])>=0",

to :

contains: "(a.textContent

a.innerText

a.firstChild.nodeValue

).indexOf(m[3])>=0",

I could setup a small testcase if you need it.

[john]

Fixed in SVN rev [3300].

[till]

Bug is back in 1.3.2. It seems since the refactoring to filters someone throw out that fix again.

So, line jquery-1.3.2.js#1944 right now is

return (elem.textContent

elem.innerText

"").indexOf(match[3]) >= 0;

but should be

return (elem.textContent

elem.innerText

$(elem).text()

"").indexOf(match[3]) >= 0;

(Tested with IE7.0 Win)

[till]

Um, next try:

return (elem.textContent || elem.innerText || $(elem).text() || "").indexOf(match[3]) >= 0;

(Well, preview showed it correctly, but pipes are wiki-tables. So, if it still got removed: between the elem-expressions there should be JavaScript-ORs)

[john]

Fixed. ​http://github.com/jeresig/sizzle/commit/1e53f41ae0ac7b8daeb3bf53e77ad8ce31980cbd