IE6 incorrect value of jQuery(window).height()

Reported by:	Q-Zma	Owned by:
Priority:	major	Milestone:	1.2.2
Component:	core	Version:	1.2
Keywords:		Cc:
Blocked by:		Blocking:

Description

In IE6 incorrect value returned, instead of min value it returns max value. Patch attached.

Attachments (1)

fix.patch (0.6 KB) - added by Q-Zma September 12, 2007 06:12PM UTC.

patch which fixes that micro bug

Change History (4)

Changed September 15, 2007 03:09AM UTC by john comment:1

milestone:	1.2 → 1.2.1
resolution:	→ fixed
status:	new → closed

This should be fixed in SVN, by brandon.

Changed September 16, 2007 08:18PM UTC by arrix comment:2

resolution:	fixed
status:	closed → reopened

The latest svn version still has some problems.

See new $(window).height() functionality in the dev list.

Here is another patch.

Index: E:/zm/jquery/jquery/src/core.js
===================================================================
--- E:/zm/jquery/jquery/src/core.js	(revision 3329)
+++ E:/zm/jquery/jquery/src/core.js	(working copy)
@@ -1115,8 +1115,8 @@
 	
 	jQuery.fn[ n ] = function(h) {
 		return this[0] == window ?
-			jQuery.browser.safari && self["inner" + name] ||
-			jQuery.boxModel && Math.max(document.documentElement["client" + name], document.body["client" + name]) ||
+			self["inner" + name] ||
+			jQuery.boxModel && document.documentElement["client" + name] ||
 			document.body["client" + name] :
 		
 			this[0] == document ?

Changed September 18, 2007 01:44PM UTC by brandon comment:3

resolution:	→ fixed
status:	reopened → closed

This is fixed in SVN. We can't use inner[Width/Height] for all browsers except IE because Opera and Mozilla include the width of the scroll bars.

Changed September 18, 2007 01:45PM UTC by brandon comment:4

milestone:	1.2.1 → 1.2.2

Side navigation