Bug Tracker

Opened 13 years ago

Closed 13 years ago

Last modified 8 years ago

#1604 closed bug (fixed)

IE6 incorrect value of jQuery(window).height()

Reported by: Q-Zma Owned by:
Priority: major Milestone: 1.2.2
Component: core Version: 1.2
Keywords: Cc:
Blocked by: Blocking:

Description

In IE6 incorrect value returned, instead of min value it returns max value. Patch attached.

Attachments (1)

fix.patch (568 bytes) - added by Q-Zma 13 years ago.
patch which fixes that micro bug

Download all attachments as: .zip

Change History (5)

Changed 13 years ago by Q-Zma

Attachment: fix.patch added

patch which fixes that micro bug

comment:1 Changed 13 years ago by john

Milestone: 1.21.2.1
Resolution: fixed
Status: newclosed

This should be fixed in SVN, by brandon.

comment:2 Changed 13 years ago by arrix

Resolution: fixed
Status: closedreopened

The latest svn version still has some problems.

See new $(window).height() functionality in the dev list.

Here is another patch.

Index: E:/zm/jquery/jquery/src/core.js
===================================================================
--- E:/zm/jquery/jquery/src/core.js	(revision 3329)
+++ E:/zm/jquery/jquery/src/core.js	(working copy)
@@ -1115,8 +1115,8 @@
 	
 	jQuery.fn[ n ] = function(h) {
 		return this[0] == window ?
-			jQuery.browser.safari && self["inner" + name] ||
-			jQuery.boxModel && Math.max(document.documentElement["client" + name], document.body["client" + name]) ||
+			self["inner" + name] ||
+			jQuery.boxModel && document.documentElement["client" + name] ||
 			document.body["client" + name] :
 		
 			this[0] == document ?

comment:3 Changed 13 years ago by brandon

Resolution: fixed
Status: reopenedclosed

This is fixed in SVN. We can't use inner[Width/Height] for all browsers except IE because Opera and Mozilla include the width of the scroll bars.

comment:4 Changed 13 years ago by brandon

Milestone: 1.2.11.2.2
Note: See TracTickets for help on using tickets.