Bug Tracker

Opened 5 years ago

Closed 5 years ago

#15228 closed bug (migrated)

Change the tag for 1.x on npm

Reported by: m_gol Owned by:
Priority: low Milestone: 1.12/2.2
Component: build Version: 2.1.1
Keywords: Cc: dmethvin
Blocked by: Blocking:

Description

It turns out when doing npm install jquery@1.x, npm actually first recognizes it's a valid semver range and doesn't look at the tag at all. This has recently caused issues for npm itself so they banned such ranges on npm master, 2.0.0 will have this rule enforced.

Therefore, we have to change the 1.x tag to something that isn't a valid semver range. This can be verified via require('semver').validRange(tagName). This should return null.

Change History (4)

comment:1 Changed 5 years ago by m_gol

We should also remove the current 1.x tag, after a year or two it's going to be banned on npm servers as well.

Perhaps we don't really need a tag since 1.x works fine as a semver range?

comment:2 Changed 5 years ago by dmethvin

Once we reversion into *two* packages this won't be an issue. Is it possible to unpublish/remove a tag? If so I don't know how.

comment:3 Changed 5 years ago by m_gol

@dmethvin It seems it's not possible now but soon will be; see https://github.com/npm/npm/issues/6243

comment:4 Changed 5 years ago by m_gol

Resolution: migrated
Status: newclosed
Note: See TracTickets for help on using tickets.