Bug Tracker

#150 closed bug (fixed)

Opened August 28, 2006 09:27PM UTC

Closed October 11, 2009 02:10PM UTC

[PATCH] slide & fade functions

Reported by: ieure Owned by:
Priority: undecided Milestone:
Component: ajax Version:
Keywords: patch Cc: ""
Blocked by: Blocking:
Description

With v1.0, the old method of doing:

$(foo).slideDown().fadeIn();

No longer works as expected. I've written convenience methods to slide up & down while fading so I can replicate this behavior with v1.0.

Attachments (2)
  • slide.2.patch (0.7 KB) - added by ieure August 28, 2006 09:28PM UTC.

    Patch implementing slide/fade convenience methods.

  • slide.patch (0.7 KB) - added by ieure August 28, 2006 09:28PM UTC.

    Patch implementing slide/fade convenience methods.

Change History (4)

Changed August 28, 2006 09:29PM UTC by ieure comment:1

I can't seem to attach the patch, so here is is, inline:

--- jquery-1.0.js.orig 2006-08-25 22:02:22.000000000 -0700

+++ jquery-1.0.js 2006-08-28 14:23:42.000000000 -0700

@@ -1253,6 +1253,21 @@

});

},

+ slideUpFade: function(speed, callback) {

+ return this.animate({height: "hide", opacity: "hide"}, speed, callback);

+ },

+

+ slideDownFade: function(speed, callback) {

+ return this.animate({height: "show", opacity: "show"}, speed, callback);

+ },

+

+ slideFadeToggle: function(speed, callback) {

+ return this.each(function() {

+ var state = $(this).is(":hidden") ? "show" : "hide";

+ $(this).animate({height: state, opacity: state}, speed, callback);

+ });

+ },

+

fadeIn: function(speed,callback){

return this.animate({opacity: "show"}, speed, callback);

},

Changed August 28, 2006 09:38PM UTC by ieure comment:2

Awesome. That won't work, either.

Here's a link: http://atomized.org/wp-content/slide.patch

Changed December 29, 2006 07:21PM UTC by montanaharki comment:3

I've run into an error when using IE7 and the same animate functionality. If I setup a slideDownFade and a slideUpFade on hover, it will only operate once. Works fine on ie6, and ff2

Changed October 11, 2009 02:10PM UTC by dmethvin comment:4

component: → ajax
description: With v1.0, the old method of doing:\ \ $(foo).slideDown().fadeIn();\ \ No longer works as expected. I've written convenience methods to slide up & down while fading so I can replicate this behavior with v1.0. → With v1.0, the old method of doing: \ \ $(foo).slideDown().fadeIn(); \ \ No longer works as expected. I've written convenience methods to slide up & down while fading so I can replicate this behavior with v1.0.
need: → Review
priority: → blocker
resolution: → fixed
status: new → closed
type: → bug