Skip to main content

Bug Tracker

Side navigation

#15078 closed bug (migrated)

Opened May 02, 2014 01:24PM UTC

Closed October 21, 2014 12:42AM UTC

Fix release script

Reported by: dmethvin Owned by:
Priority: low Milestone: 1.12/2.2
Component: build Version: 1.11.1
Keywords: Cc: scott_gonzalez
Blocked by: Blocking:
Description

This is a meta-ticket for the problems I encountered during the 1.11.1/2.1.1 release, some of these will be jquery-release issues and others with core's release.js script.

  • The 1.x release tries to update jquery.js and jquery-latest.js on the CDN and fails, we if we're not going to update these anymore and freeze them at 1.11.1 we can just remove that from core's release.js.
  • I've now had npm publish --tag fail on me in two different releases. It worked for the 2.x but failed on 1.x. As a result I ended up doing the subsequent steps manually there. (Note that npm publish --tag 1.x worked fine manually both times!) Since npm is independent from the later steps there should be an idea of "error but you can continue" in jquery-release to simplify error recovery and minimize the mess.
  • The CDN zip files created by release.js were empty (0 bytes) for the 2.x release. I didn't get that far with 1.x because of the npm error.
  • The build script never came back to a shell prompt even after I got the "complete" message; perhaps related to why the zip files were empty.
  • The version for package.json didn't seem to happen on master so I did it manually.
  • The version wasn't updated in bower.json either, it was in the old non-semver format as well. Does this need to be in the repo full-time, or can it just exist in the tagged release?
Attachments (0)
Change History (2)

Changed May 02, 2014 01:31PM UTC by dmethvin comment:1

cc: → scott_gonzalez
component: unfiledbuild
description: This is a meta-ticket for the problems I encountered during the 1.11.1/2.1.1 release, some of these will be jquery-release issues and others with core's release.js script. \ \ * The 1.x release tries to update jquery.js and jquery-latest.js on the CDN and [http://upload.wnd8.com/grab/fc4dcf.png fails], we if we're not going to update these anymore and freeze them at 1.11.1 we can just remove that from core's release.js. \ \ * I've now had `npm publish --tag` fail on me in two different releases. It worked for the 2.x but [http://upload.wnd8.com/grab/3d36ff.png failed] on 1.x. As a result I ended up doing the subsequent steps manually there. (Note that `npm publish --tag 1.x` worked fine manually both times!) Since npm is independent from the later steps there should be an idea of "error but you can continue" in jquery-release to simplify error recovery and minimize the mess. \ \ * The CDN zip files created by release.js were empty (0 bytes) for the 2.x release. I didn't get that far with 1.x because of the npm error. \ \ * The build script never came back to a shell prompt even after I got the [https://github.com/jquery/jquery-release/blob/705bcf6b850f3c4537e9bff44dfabebf396459e7/release.js#L12 "complete" message]; perhaps related to why the zip files were empty.This is a meta-ticket for the problems I encountered during the 1.11.1/2.1.1 release, some of these will be jquery-release issues and others with core's release.js script. \ \ * The 1.x release tries to update jquery.js and jquery-latest.js on the CDN and [http://upload.wnd8.com/grab/fc4dcf.png fails], we if we're not going to update these anymore and freeze them at 1.11.1 we can just remove that from core's release.js. \ \ * I've now had `npm publish --tag` fail on me in two different releases. It worked for the 2.x but [http://upload.wnd8.com/grab/3d36ff.png failed] on 1.x. As a result I ended up doing the subsequent steps manually there. (Note that `npm publish --tag 1.x` worked fine manually both times!) Since npm is independent from the later steps there should be an idea of "error but you can continue" in jquery-release to simplify error recovery and minimize the mess. \ \ * The CDN zip files created by release.js were empty (0 bytes) for the 2.x release. I didn't get that far with 1.x because of the npm error. \ \ * The build script never came back to a shell prompt even after I got the [https://github.com/jquery/jquery-release/blob/705bcf6b850f3c4537e9bff44dfabebf396459e7/release.js#L12 "complete" message]; perhaps related to why the zip files were empty. \ \ * The version for `package.json` didn't seem to happen on master so I [https://github.com/jquery/jquery/commit/568f3dd84693629768b40e7b5cf4c60e0c57c4d4 did it manually]. \ \ * The version [https://github.com/jquery/jquery/commit/2f46ac8091d8b2612c56280e7a5626f9142bb1cf wasn't updated] in `bower.json` either, it was in the old non-semver format as well. Does this need to be in the repo full-time, or can it just exist in the tagged release?
milestone: None1.12/2.2
priority: undecidedlow
status: newopen

Changed October 21, 2014 12:42AM UTC by m_gol comment:2

resolution: → migrated
status: openclosed