Opened 16 years ago
Closed 13 years ago
#150 closed bug (fixed)
[PATCH] slide & fade functions
Reported by: | ieure | Owned by: | |
---|---|---|---|
Priority: | undecided | Milestone: | |
Component: | ajax | Version: | |
Keywords: | patch | Cc: | "" |
Blocked by: | Blocking: |
Description (last modified by )
With v1.0, the old method of doing:
$(foo).slideDown().fadeIn();
No longer works as expected. I've written convenience methods to slide up & down while fading so I can replicate this behavior with v1.0.
Attachments (2)
Change History (6)
Changed 16 years ago by
Attachment: | slide.patch added |
---|
Changed 16 years ago by
Attachment: | slide.2.patch added |
---|
Patch implementing slide/fade convenience methods.
comment:1 Changed 16 years ago by
I can't seem to attach the patch, so here is is, inline:
--- jquery-1.0.js.orig 2006-08-25 22:02:22.000000000 -0700 +++ jquery-1.0.js 2006-08-28 14:23:42.000000000 -0700 @@ -1253,6 +1253,21 @@
});
},
+ slideUpFade: function(speed, callback) { + return this.animate({height: "hide", opacity: "hide"}, speed, callback); + }, + + slideDownFade: function(speed, callback) { + return this.animate({height: "show", opacity: "show"}, speed, callback); + }, + + slideFadeToggle: function(speed, callback) { + return this.each(function() { + var state = $(this).is(":hidden") ? "show" : "hide"; + $(this).animate({height: state, opacity: state}, speed, callback); + }); + }, +
fadeIn: function(speed,callback){
return this.animate({opacity: "show"}, speed, callback);
},
comment:2 Changed 16 years ago by
Awesome. That won't work, either.
Here's a link: http://atomized.org/wp-content/slide.patch
comment:3 Changed 16 years ago by
I've run into an error when using IE7 and the same animate functionality. If I setup a slideDownFade and a slideUpFade on hover, it will only operate once. Works fine on ie6, and ff2
comment:4 Changed 13 years ago by
Component: | → ajax |
---|---|
Description: | modified (diff) |
need: | → Review |
Priority: | → blocker |
Resolution: | → fixed |
Status: | new → closed |
Type: | → bug |
Patch implementing slide/fade convenience methods.