missing argument declaration

[Fredrik Blomqvist]

the "completed" function (called from jQuery.ready.promise) seems to miss declaring argument "event" (1.10.2 has it).

function completed(/* event? */) {
	// readyState === "complete" is good enough for us to call the dom ready in oldIE
	if ( document.addEventListener || event.type === "load" || document.readyState === "complete" ) {
		detach();
		jQuery.ready();
	}
}

I.e it will currently throw an error in a browser that doesn't have an addEventListener.

[timmywil]

Thanks for taking the time to contribute to the jQuery project! Please provide a complete reduced test case on jsFiddle to help us assess your ticket.

Additionally, be sure to test against the "jQuery(edge)" version to ensure the issue still exists—you may need to change this to a specific version depending on the test case.

To get you started, use the appropriate boilerplate:

• jQuery 1.x ​http://jsfiddle.net/FrKyN/
• jQuery 2.x ​http://jsfiddle.net/VUp3e/

Open the link and click to "Fork" (in the top menu) to begin.

Also, please read:

• ​http://blog.jquery.com/2013/03/01/jquery-2-0-beta-2-released/
• ​http://blog.jquery.com/2013/01/15/jquery-1-9-final-jquery-2-0-beta-migrate-final-released/

Additional resources:

• Won't Fix: ​http://contribute.jquery.org/wont-fix/
• CLA: ​http://contribute.jquery.org/CLA/
• Style Guide: ​http://contribute.jquery.org/style-guide/js/

[trac-o-bot]

Because we get so many tickets, we often need to return them to the initial reporter for more information. If that person does not reply within 14 days, the ticket will automatically be closed, and that has happened in this case. If you still are interested in pursuing this issue, feel free to add a comment with the requested information and we will be happy to reopen the ticket if it is still valid. Thanks!