Skip to main content

Bug Tracker

Side navigation

#14917 closed bug (fixed)

Opened March 26, 2014 02:47AM UTC

Closed March 27, 2014 02:03PM UTC

Last modified March 27, 2014 11:22PM UTC

1.8.3+1 missing jquery.js

Reported by: Owned by:
Priority: low Milestone: 1.11.1/2.1.1
Component: build Version: 1.8.3
Keywords: Cc:
Blocked by: Blocking:

1.8.3 tag contains jquery.js in the root level directory whereas 1.8.3+1 does not. Anyone using jquery from bower and relying on this file cannot redirect bower to 1.8.3 specifically.

Attachments (0)
Change History (10)

Changed March 26, 2014 02:51AM UTC by dmethvin comment:1

owner: →
status: newpending

We don't intend to go back and re-tag all the releases that predate our start of Bower support. Can you suggest a solution that doesn't require re-tagging?

Changed March 26, 2014 02:55AM UTC by comment:2

status: pendingnew

Tagging a 1.8.3+2 which includes the jquery.js should fix the problem

Changed March 26, 2014 02:57AM UTC by dmethvin comment:3

status: newpending

Okay, I should add that we don't intend to go back and re-tag releases each time someone asks for an old release. Can you suggest a solution that doesn't require re-tagging?

Changed March 26, 2014 03:55AM UTC by comment:4

Hey Dave,

The "jquery.js" file in the root seems to have been a convention since the release of 1.2.3 (in 1.8.3 you guys started including the minified file). Also, the commit message on the "jquery.js" file reads on every release since 1.2.3 "Include distribution in release tag". This indicates pretty clearly to an API consumer that the file can be depended on making it an API breaking change and not ok to remove in a suffixed maintenance release.

Another issue is that semantic versioning indicates 1.8.3 can match 1.8.3+1, so Bower or not, it makes it difficult to depend on 1.8.3 specifically using any sort of automation. It might be worth noting that "+" versions, I've observed, are only generally used as part of a semantic version suffix such as alpha, beta or rc. I could be wrong, though, since the semver specification doesn't explicitly say anything about that.

For what it's worth, I believe that tagging a 1.8.3+2 release is the right thing to do and is in the best interest of the greater jQuery community.

Changed March 26, 2014 04:05PM UTC by timmywil comment:5

I know it's not particularly kosher, but we've already rebuilt all of the tags that corresponded to Component tags. Rebuilding this one would not be very difficult. I've thrown up a sample here.

Changed March 27, 2014 12:02AM UTC by dmethvin comment:6

status: pendingopen

Ok, I was totally confused. My local master didn't have the updated tags that timmywil pushed, which I just fixed. So if it's just about fixing this one tag, that seems okay.

Changed March 27, 2014 12:04AM UTC by dmethvin comment:7

component: unfiledbuild
milestone: None1.11.1/2.1.1
priority: undecidedlow

Changed March 27, 2014 02:03PM UTC by timmywil comment:8

resolution: → fixed
status: openclosed

Changed March 27, 2014 11:20PM UTC by anonymous comment:9


Changed March 27, 2014 11:22PM UTC by comment:10

Thankyou, much appreciated